[server] log all deletion eligibility time updates #20497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptronicek
commented
Jan 6, 2025
| @@ -1,4 +1,4 @@ | |||
| // Copyright (c) 2024 Gitpod GmbH. All rights reserved. | |||
| // Copyright (c) 2025 Gitpod GmbH. All rights reserved. | |||
Member
Author
There was a problem hiding this comment.
I take 0 accountability for this
they machine did it
geropl
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR, I propose to log all garbage collection threshold changes for all regular workspaces. With, we'll be able to better understand the GC lifecycle of a single workspace when investigating false soft deletions.
The drawback I see here is that we'll most likely get a lot of these logs - most notably since we call
updateDeletionEligibilityTimeevery time onupdateGitStatus.Related Issue(s)
Related to https://gitpod.slack.com/archives/C071G5TTS49/p1734686954620309
How to test